Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add v5.1 in pull_request_template.md #5705

Merged
merged 1 commit into from
May 27, 2021
Merged

Add v5.1 in pull_request_template.md #5705

merged 1 commit into from
May 27, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented May 27, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Add v5.1 in pull_request_template.md.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn requested a review from qiancai May 27, 2021 06:52
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 27, 2021
@TomShawn TomShawn added needs-cherry-pick-release-2.1 require-LGT1 Indicates that the PR requires an LGTM. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels May 27, 2021
@ti-chi-bot ti-chi-bot removed the missing-translation-status This PR does not have translation status info. label May 27, 2021
@qiancai
Copy link
Collaborator

qiancai commented May 27, 2021

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • qiancai

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 30676ac

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 27, 2021
@ti-chi-bot ti-chi-bot merged commit b89c917 into master May 27, 2021
@TomShawn TomShawn deleted the TomShawn-patch-2 branch May 27, 2021 06:55
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5706.

This was referenced May 27, 2021
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5707.

@ti-chi-bot ti-chi-bot mentioned this pull request May 27, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5708.

@ti-chi-bot ti-chi-bot mentioned this pull request May 27, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5709.

@ti-chi-bot ti-chi-bot mentioned this pull request May 27, 2021
Merged
10 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #5710.

ti-chi-bot added a commit that referenced this pull request May 27, 2021
@ti-chi-bot
Add v5.1 in pull_request_template.md (#5705) (#5707)
4f9e438
ti-chi-bot added a commit that referenced this pull request May 27, 2021
@ti-chi-bot
Add v5.1 in pull_request_template.md (#5705) (#5709)
1a32139
ti-chi-bot added a commit that referenced this pull request May 27, 2021
@ti-chi-bot
Add v5.1 in pull_request_template.md (#5705) (#5706)
a14d31d
ti-chi-bot added a commit that referenced this pull request May 27, 2021
@ti-chi-bot
Add v5.1 in pull_request_template.md (#5705) (#5708)
5fff54c
ti-chi-bot added a commit that referenced this pull request May 27, 2021
@ti-chi-bot
Add v5.1 in pull_request_template.md (#5705) (#5710)
d6c8d99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiancai qiancai Awaiting requested review from qiancai

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @qiancai @ti-chi-bot